Skip to content

feat: Add support for unix_timestamp function #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andygrove wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: Add support for unix_timestamp function #2936

andygrove wants to merge 12 commits into from

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Dec 18, 2025 •
edited
Loading

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

  • Add support for unix_timestamp for timestamp and date inputs
  • Move all temoral expression serde into expression registry

How are these changes tested?

Benchmarks

Performance is not great:

OpenJDK 64-Bit Server VM 11.0.22+7-LTS on Mac OS X 14.6.1
Apple M3 Max
Unix Timestamp from Timestamp (UTC):          Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
----------------------------------------------------------------------------------------------------------------------------
Unix Timestamp from Timestamp (UTC) - Spark              31             46          11         34.3          29.1       1.0X
Unix Timestamp from Timestamp (UTC) - Comet              37             55          13         28.7          34.9       0.8X

OpenJDK 64-Bit Server VM 11.0.22+7-LTS on Mac OS X 14.6.1
Apple M3 Max
Unix Timestamp from Date (UTC):           Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
Unix Timestamp from Date (UTC) - Spark               43             58          14         24.6          40.6       1.0X
Unix Timestamp from Date (UTC) - Comet               31             47          17         34.2          29.2       1.4X

OpenJDK 64-Bit Server VM 11.0.22+7-LTS on Mac OS X 14.6.1
Apple M3 Max
Unix Timestamp from Timestamp (America/Los_Angeles):          Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
--------------------------------------------------------------------------------------------------------------------------------------------
Unix Timestamp from Timestamp (America/Los_Angeles) - Spark              27             51          18         39.4          25.4       1.0X
Unix Timestamp from Timestamp (America/Los_Angeles) - Comet              33             54          13         31.6          31.6       0.8X

OpenJDK 64-Bit Server VM 11.0.22+7-LTS on Mac OS X 14.6.1
Apple M3 Max
Unix Timestamp from Date (America/Los_Angeles):          Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
---------------------------------------------------------------------------------------------------------------------------------------
Unix Timestamp from Date (America/Los_Angeles) - Spark              58             84          19         18.0          55.6       1.0X
Unix Timestamp from Date (America/Los_Angeles) - Comet              61             79          15         17.3          57.7       1.0X

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.61%. Comparing base (f09f8af) to head (d7ffc2e).
⚠️ Report is 783 commits behind head on main.

Files with missing lines Patch % Lines
...c/main/scala/org/apache/comet/serde/datetime.scala 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2936      +/-   ##
============================================
+ Coverage     56.12%   59.61%   +3.48%     
- Complexity      976     1381     +405     
============================================
  Files           119      167      +48     
  Lines         11743    15506    +3763     
  Branches       2251     2569     +318     
============================================
+ Hits           6591     9244    +2653     
- Misses         4012     4961     +949     
- Partials       1140     1301     +161

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove marked this pull request as ready for review December 20, 2025 16:48
parthchandra
parthchandra reviewed Jan 8, 2026
View reviewed changes
native/proto/src/proto/expr.proto
EmptyExpr monotonically_increasing_id = 64;
FromJson from_json = 89;
UnixTimestamp unix_timestamp = 65;
FromJson from_json = 66;
Copy link
Contributor

@parthchandra parthchandra Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is bad form to renumber protobuf fields.

native/spark-expr/src/datetime_funcs/unix_timestamp.rs
.try_into()
.map_err(|_| internal_datafusion_err!("unix_timestamp expects exactly one argument"))?;

match args {
Copy link
Contributor

@parthchandra parthchandra Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Input could be Timestamp with no timezone. Do you need to handle that differently?

native/spark-expr/src/datetime_funcs/unix_timestamp.rs

Ok(ColumnarValue::Array(Arc::new(result)))
}
_ => Err(DataFusionError::Execution(format!(
Copy link
Contributor

@parthchandra parthchandra Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe input to unix_timestamp could be a string (and an optional format)
https://spark.apache.org/docs/latest/api/sql/index.html#unix_timestamp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthchandra parthchandra parthchandra left review comments

@mbutrovich mbutrovich Awaiting requested review from mbutrovich

@comphead comphead Awaiting requested review from comphead

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andygrove @codecov-commenter @parthchandra